cats: remove dynamic catalog backends#1392
Conversation
6de9372 to
af9b9f1
Compare
04edadf to
a25db5f
Compare
arogge
left a comment
There was a problem hiding this comment.
This looks mostly great. I'm unhappy with the removed test - we should probably have a replacement for that.
Also we might want to discuss if we deprecate "Backend Directories" in 22.1, so people don't trip when upgrading to 23.
core/src/dird/CMakeLists.txt
Outdated
| add_library(dird_objects STATIC ${DIRD_OBJECTS_SRCS}) | ||
| target_link_libraries( | ||
| dird_objects PRIVATE bareos ${OPENSSL_LIBRARIES} Threads::Threads | ||
| dird_objects PRIVATE bareos bareossql ${OPENSSL_LIBRARIES} Threads::Threads |
There was a problem hiding this comment.
I don't see why this should suddenly require bareossql. Did you run into any issues while building?
| void test_CFG_TYPE_STR_VECTOR_OF_DIRS(DirectorResource* me) | ||
| { | ||
| EXPECT_EQ(me->backend_directories.size(), 9); | ||
| /* | ||
| * WIN32: | ||
| * cmake uses some value for PATH_BAREOS_BACKENDDIR, | ||
| * which ends up in the configuration files | ||
| * but this is later overwritten in the Director Daemon with ".". | ||
| * Therefore we skip this test. | ||
| */ | ||
| #if !defined(HAVE_WIN32) | ||
| EXPECT_EQ(me->backend_directories.at(0), PATH_BAREOS_BACKENDDIR); | ||
| #endif | ||
| } | ||
|
|
||
| TEST(ConfigParser_Dir, CFG_TYPE_STR_VECTOR_OF_DIRS) | ||
| { | ||
| test_config_directive_type(test_CFG_TYPE_STR_VECTOR_OF_DIRS); | ||
| } | ||
|
|
There was a problem hiding this comment.
while we obviously cannot test with backend_directories anymore, we should probably still test that type.
| The main purpose of :program:`bareos-dbcopy` is to migrate an existing Bareos | ||
| installation from |mysql| to |postgresql|. Therefore the required | ||
| :config:option:`dir/catalog/DbDriver` in the ``<sourcecatalog>`` is |mysql|, and | ||
| ``dir/catalog/DbDriver`` in the ``<sourcecatalog>`` is |mysql|, and |
There was a problem hiding this comment.
Didn't we remove dbcopy in an earlier PR? Why do we still keep its manpage?
We should definitely still point people at the tool, that existed in prior versions, but I guess it is sufficient if the documentation is present in that version...
65d7cff to
89000a8
Compare
89000a8 to
28a2a11
Compare
|
I tried installing just Old behaviour: New behaviour: I'm not saying that's a problem. It might just be a change we were not (yet) aware of. |
Thank you for contributing to the Bareos Project!
Description
This PR removes the catalog backends mechanism as it is no longer necessary since we now only support PostgreSQL.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality