VMware Plugin: fix restore to different vmname#1390
Merged
Conversation
bruno-at-bareos
requested changes
Feb 27, 2023
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks for the fix, we need to agree on commit/PR title and adding or not the documentation line about how to restore vm with another name.
We should maybe extend the tests to restore with another name, and check the vm list with vmware_cbt_tool.py so major changes wouldn't be forgot on that one too.
bruno-at-bareos
requested changes
Feb 28, 2023
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
We need to integrate a picture for the webui, and also make coherent the option used
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
bruno-at-bareos
approved these changes
Mar 1, 2023
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
The PR is now ready for merge
Bugfix for restore to different vmname in same folder failing with duplicate name error. Check for invalid plugin option also works correctly now for both plugin options and config file.
Clarify the use of plugin options in the Bareos VMware Plugin, especially on restore and when using the Bareos WebUI.
Co-authored-by: Bruno Friedmann @bareos <89836284+bruno-at-bareos@users.noreply.github.com>
f9c7099 to
a8a688b
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for restore to different vmname in same folder failing with duplicate name error. Check for invalid plugin option also works correctly now for both plugin options and config file.
Thank you for contributing to the Bareos Project!
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality