Skip to content

improvements to pr-tool#1389

Merged
arogge merged 5 commits intobareos:masterfrom
arogge:dev/arogge/master/changelog-bot
Feb 23, 2023
Merged

improvements to pr-tool#1389
arogge merged 5 commits intobareos:masterfrom
arogge:dev/arogge/master/changelog-bot

Conversation

@arogge
Copy link
Member

@arogge arogge commented Feb 23, 2023

  • pr-tool will now honor the PR labels "bugfix" and "removal" when determining the changelog section
  • when encountering a commit message that is a single line with no end-of-line marker at the end, pr-tool will no longer crash
  • if your local repository is not up-to-date pr-tool will now refuse to merge

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

This fixes the check that determines if your local repository is up to
date and lets the merge subcommand fail if you're not up to date.
When a PR has the label "Bugfix" its Changelog record will now be added
to the "Fixed" section instead of the "Changed" section by default.
When a PR has the label "Removal" its Changelog record will now be added
to the "Removed" section instead of the "Changed" section by default.
@arogge arogge force-pushed the dev/arogge/master/changelog-bot branch from 968b978 to 2072f48 Compare February 23, 2023 14:11
@arogge arogge requested a review from sebsura February 23, 2023 14:12
@arogge arogge force-pushed the dev/arogge/master/changelog-bot branch from 3f96771 to f7ea6d1 Compare February 23, 2023 16:02
@arogge arogge merged commit 50d68f3 into bareos:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants