vmware_cbt_tool.py: pyVmomi 8.x compatibility#1386
Merged
arogge merged 2 commits intobareos:masterfrom Mar 1, 2023
Merged
Conversation
1bc677b to
83ed1c0
Compare
-In pyVmomi 8.0 the SmartConnectNoSSL() method was removed. This change uses SmartConnect with the disableSslCertValidation=True parameter instead. As it was added in pyVmomi 7.0.2 this is now the minimum required version, this was added to the documentation. backport of #da94e4df3 Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
dda746d to
f7d2bf1
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backport the fix #da94e4df3 to fix pyVmomi 8.0 compatibility to the tool
It would be great to have both backported to 21.
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality