Skip to content

core: remove deprecated make_catalog_backup.pl#1378

Merged
arogge merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/remove-deprecated-make_catalog_backup.pl
Feb 23, 2023
Merged

core: remove deprecated make_catalog_backup.pl#1378
arogge merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/remove-deprecated-make_catalog_backup.pl

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Feb 14, 2023

Since version 22 make_catalog_backup.pl has been replaced by make_catalog_backup posix script, this PR aims to remove this tools and references.

Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/remove-deprecated-make_catalog_backup.pl branch from 93e73c3 to 1b9568c Compare February 14, 2023 14:29
@arogge
Copy link
Member

arogge commented Feb 14, 2023

you can also remove the now no more generated file from .gitignore

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/remove-deprecated-make_catalog_backup.pl branch from 1b9568c to 36578bf Compare February 14, 2023 15:20
@bruno-at-bareos
Copy link
Contributor Author

bruno-at-bareos commented Feb 14, 2023

@arogge

you can also remove the now no more generated file from .gitignore

nice catch, as any official review process has started, I've used the magic force ;-)

@arogge arogge added the removal this PR removes functionality label Feb 23, 2023
@arogge arogge force-pushed the dev/bruno/master/remove-deprecated-make_catalog_backup.pl branch from 36578bf to c06433c Compare February 23, 2023 13:38
bruno-at-bareos and others added 2 commits February 23, 2023 14:46
- since version 22 make_catalog_backup.pl has been replaced by
  make_catalog_backup posix script

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@arogge arogge force-pushed the dev/bruno/master/remove-deprecated-make_catalog_backup.pl branch from 3a4d61a to 65b53a0 Compare February 23, 2023 13:46
@arogge arogge merged commit 0658e55 into bareos:master Feb 23, 2023
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/remove-deprecated-make_catalog_backup.pl branch February 27, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

removal this PR removes functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants