cats: remove remains of deprecated databases#1377
Merged
arogge merged 16 commits intobareos:masterfrom Feb 28, 2023
Merged
Conversation
f41673f to
7c5238d
Compare
6f6111e to
c6a1e63
Compare
fd32ab8 to
abfaac3
Compare
arogge
requested changes
Feb 27, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
We should still mention that you can migrate a MySQL catalog to PostgreSQL using dbcopy from a specific Bareos version.
| .. include:: Howtos/UseADummyDeviceToTestTheBackup.rst.inc | ||
| .. include:: Howtos/BackupOfThirdPartyDatabases.rst.inc | ||
| .. include:: Howtos/MigrateABareosCatalogFromMySqlToPostgresql.rst.inc | ||
| .. include:: Howtos/StatisticsCollection.rst.inc |
Member
There was a problem hiding this comment.
Maybe we should not remove any reference on how to migrate from MySQL yet.
Comment on lines
-367
to
-370
| One exception is when using a |mysql| Bareos catalog, | ||
| which have been removed with Bareos :sinceVersion:`21.0.0: MySQL backend removed`. | ||
| Therefore you first have to upgrade to Bareos 20 and migrate the |mysql| into a |postgresql| Bareos Catalog, see :ref:`section-MigrationMysqlToPostgresql`. | ||
|
|
Member
There was a problem hiding this comment.
see my comment above, we should probably still mention that you may need to do this. Some people may still want upgrade from Bareos 16.2 (or something like that) to 22.
added 4 commits
February 27, 2023 14:22
SQLITE3_INIT_QUERY HAVE_SQLITE3 HAVE_SQLITE3_THREAD_SAFE
added 9 commits
February 27, 2023 14:22
abfaac3 to
0c10f4a
Compare
arogge
requested changes
Feb 27, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
Also, bareos-check-sources lists a lot of header's with wrong years in them.
arogge
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all what remains of deprecated databases (MySql, SQLite, Ingres, DBI) from the codebase.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality