build: replace sprintf by snprintf due to upgraded MacOS compiler, change linking of googletest#1361
Merged
pstorz merged 3 commits intobareos:masterfrom Jan 23, 2023
Merged
Conversation
pstorz
approved these changes
Jan 23, 2023
77a46a5 to
182fe5d
Compare
Make the dependency from stored_objects to Threads::Threads explicit.
182fe5d to
0bb53ae
Compare
Newer MacOS compilers consider sprintf() deprecated. This patch replaces the uses of sprintf() with snprintf() for all code that is compiled for the file daemon on MacOS.
0bb53ae to
495dfd7
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix broken build due to MacOS deprecating
sprintf()and missing dependency to Threads::Threads (that was uncovered when switching googletest from static to dynamic linking)Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality