dird: enable default options in fileset config when no options are explicitly specified#1357
Merged
pstorz merged 4 commits intobareos:masterfrom Mar 2, 2023
Conversation
a2f79ad to
a5a6190
Compare
pstorz
requested changes
Feb 24, 2023
pstorz
approved these changes
Mar 2, 2023
a5a6190 to
e2abf46
Compare
60b4b88 to
eebf74e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a fileset configuration does not include an
optionssection, the default values would not be applied. Defaults would only apply when the config parser finds anoptionssection.This PR makes sure default options are set even when no options section is specified.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsTests