docs: release note remove warning about binaries#1354
Conversation
joergsteffens
left a comment
There was a problem hiding this comment.
This is an improvement, but I'd formulate some things differently.
| Bareos Binary Release Policy | ||
| ---------------------------- | ||
|
|
||
| .. _section-BareosRepositoryTypes: |
There was a problem hiding this comment.
Why have moved this below the section title? IMHO it belongs above the title. Multiple section labels are not a problem.
There was a problem hiding this comment.
I've to check again, but the linking to that section was not working as expected when below.
But for coherency, the section title BareosRepositoryTypes is now correctly placed, as if we add some content after
Bareos Binary Release Policy like for example time schedule etc, the next section (Repository) would no more be well placed.
There was a problem hiding this comment.
Don't know what was not working, restested and it works. Would you like to see this title going back before the section?
There was a problem hiding this comment.
Either move it above the section title (as this ref is also called "section-") or remove it completely, as it is not used anymore anyway.
joergsteffens
left a comment
There was a problem hiding this comment.
I added the CHANGELOG. Fixing the section ref would be nice, but otherwise approved the PR.
| Bareos Binary Release Policy | ||
| ---------------------------- | ||
|
|
||
| .. _section-BareosRepositoryTypes: |
There was a problem hiding this comment.
Either move it above the section title (as this ref is also called "section-") or remove it completely, as it is not used anymore anyway.
- since new Bareos Binary Policy for >= 22, warning is none - add pointer to the corresponding section Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- add a note section to explain in detailled human words what's behing ~pre binary build in current. - clarify next major changes in both repositories. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> Co-authored-by: Jörg Steffens <joergsteffens@users.noreply.github.com>
a275cdf to
9699412
Compare
|
Done. |
This PR remove the warning section of release note page and add a note to new Binary Policy page to explain more deeply what
<next-version-number>~preis with example.OP #5373
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality