Python Plugins: Avoid pop(0) performance impact#1351
Merged
Conversation
Python plugins should use collections.deque with popleft() instead of lists with pop(0) as it incurs O(n) memory movement costs which causes performance issues on large lists.
arogge
approved these changes
Jan 18, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
Code changes look great. I ran the py2plug-fd-ldap test and it still passes. Not sure for the OpenVZ plugin though.
Do you think we should backport these changes to 22?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python plugins should use collections.deque with popleft() instead of lists with pop(0) as it incurs O(n) memory movement costs which causes performance issues on large lists.
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.Source code quality
bareos-check-sources --since-mergedoes not report any problems