dird: cats: adapt purge command to delete jobs with specific jobstatus and/or from specific pool#1349
Merged
joergsteffens merged 11 commits intobareos:masterfrom Mar 24, 2023
Conversation
purgecommand to delete jobs with specific jobstatus and/or from specific poolpurge command to delete jobs with specific jobstatus and/or from specific pool
b0777a0 to
3cf3905
Compare
3cf3905 to
94842fb
Compare
joergsteffens
requested changes
Jan 20, 2023
Member
|
I also did some modifications directly in commits. Unfortunately, I'd not have the permission to modify this PR directly (I though, did is the default?). Instead I pushed my suggestions to https://github.com/joergsteffens/bareos/tree/dev/joergs/master/s5201-purge-failed-jobs |
94842fb to
31c0033
Compare
joergsteffens
requested changes
Mar 16, 2023
Member
There was a problem hiding this comment.
Nearly done, but pr-tool complains:
✗ Commit checks failed:
f874336d4 refactor: systemtest: updated systemtest: body contains line longer 72 chars
aa771a59e refactor: ua_purge.cc: remove bailouts, rename and reorder variables: headline too long
✗ bareos-check-sources --since=421f8eb125967d7faac63cf9acf0eddff16d2244 reported:
Plugin 'compress c block comments' would modify 'core/src/cats/sql.cc'
Plugin 'fix copyright year' would modify 'core/src/cats/sql.cc'
Plugin 'fix copyright year' would modify 'core/src/cats/sql.h'
2dd2535 to
443ea4a
Compare
* remove bailout * rename and reorder variables
443ea4a to
03efdeb
Compare
joergsteffens
approved these changes
Mar 23, 2023
* removed debug level to reduce log clutter, as required messages show up in joblog messages * updated expect grep to show what was found instead of expected value, and updated testrunner to use it * renamed log files
added 3 commits
March 23, 2023 13:11
update tests using purge without confirmation
03efdeb to
d12e8b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Description
This PR adds the ability for the
purgecommand to delete jobs with a specific jobstatus and/or from specific pool.The command used to only do so for specific volumes or clients.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.Source code quality
bareos-check-sources --since-mergedoes not report any problemsTests