Skip to content

cats: fix issue where startfile field gets wrongly updated#1346

Merged
pstorz merged 3 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-startfile-issue
Jan 2, 2023
Merged

cats: fix issue where startfile field gets wrongly updated#1346
pstorz merged 3 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-startfile-issue

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Jan 2, 2023

Thank you for contributing to the Bareos Project!

Description

This PR fixes an issue where a jobmedia table update would unnecessarily update the startfile field.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@alaaeddineelamri alaaeddineelamri changed the title cats: fix issue where starfile field gets wrongly updated cats: fix issue where startfile field gets wrongly updated Jan 2, 2023
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-startfile-issue branch from 22dcb18 to 2887544 Compare January 2, 2023 13:16
@pstorz pstorz self-assigned this Jan 2, 2023
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-startfile-issue branch from 2887544 to ad450ce Compare January 2, 2023 13:29
@pstorz pstorz self-requested a review January 2, 2023 15:40
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work!

@pstorz pstorz merged commit d6ac60d into bareos:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants