filed: stored: remove deprecated compatible option from configuration #1341
Merged
pstorz merged 6 commits intobareos:masterfrom Mar 30, 2023
Conversation
b3aabe6 to
c1921d6
Compare
c1921d6 to
d6e12f9
Compare
d6e12f9 to
f8b4b9b
Compare
f8b4b9b to
982ded7
Compare
9eeffe1 to
d9b1e75
Compare
pstorz
requested changes
Mar 21, 2023
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work!
Now that we remove the compatible settings we can remove every reference to bacula compatibility.
| To be sure this is enabled you can explicitly set the compatible option: | ||
|
|
||
| :config:option:`fd/client/Compatible = True`\ | ||
| A Director and a Storage Daemon should (must) always run at the same version. This is true for Bareos as well as for Bacula. It is not possible to mix these components. This is because the protocol between Director and Storage Daemon itself is not versioned (also true for Bareos and Bacula). |
Member
There was a problem hiding this comment.
I would say we can get rid of the whole chapter of bacula compatibility. It is not needed anymore.
b2a7493 to
60b84d4
Compare
1852a88 to
82c6799
Compare
added 5 commits
March 24, 2023 16:25
remove bacula compatibility chapter
... from filed/dir_cmd as they were developed to only be compatible with old versions
82c6799 to
e5d7ade
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Description
This PR removes the deprecated
compatibleoption from the configuration and all functionality that is linked to it.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems