Skip to content

systemtests: rename virtualfull -> virtualfull-basic ,bareos -> bareos-basic, bconsole -> bconsole-basic#1339

Merged
arogge merged 6 commits intomasterfrom
dev/pstorz/master/rename-virtualfull-test
Feb 2, 2023
Merged

systemtests: rename virtualfull -> virtualfull-basic ,bareos -> bareos-basic, bconsole -> bconsole-basic#1339
arogge merged 6 commits intomasterfrom
dev/pstorz/master/rename-virtualfull-test

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Dec 22, 2022

When systemtests have the same basename, the shutdown scripts for the daemons get confused and might kill the wrong process when tests run in parallel.

This PR renames the virtualfull test so that it cannot clash with virtualfull-bscan.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@pstorz pstorz changed the title systemtests: rename virtualfull -> virtualfull-basic systemtests: rename virtualfull -> virtualfull-basic Dec 22, 2022
@pstorz pstorz requested a review from arogge December 22, 2022 17:11
@pstorz pstorz self-assigned this Dec 22, 2022
@bruno-at-bareos bruno-at-bareos requested review from alaaeddineelamri and removed request for arogge January 12, 2023 11:27
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/rename-virtualfull-test branch from b9000b8 to 759a522 Compare January 13, 2023 13:39
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/rename-virtualfull-test branch from 759a522 to 42a975c Compare January 13, 2023 13:57
@pstorz pstorz changed the title systemtests: rename virtualfull -> virtualfull-basic systemtests: rename virtualfull -> virtualfull-basic ,bareos -> bareos-basic, bconsole -> bconsole-basic Jan 30, 2023
@pstorz pstorz force-pushed the dev/pstorz/master/rename-virtualfull-test branch from 42a975c to a89ccc6 Compare January 30, 2023 16:22
@pstorz pstorz force-pushed the dev/pstorz/master/rename-virtualfull-test branch from 329d401 to 52b3ff3 Compare January 31, 2023 09:16
@arogge arogge force-pushed the dev/pstorz/master/rename-virtualfull-test branch from a9b67d0 to 2eda822 Compare February 2, 2023 14:17
@arogge arogge force-pushed the dev/pstorz/master/rename-virtualfull-test branch from 2eda822 to 9a6c99d Compare February 2, 2023 14:19
@arogge arogge merged commit 4e47b98 into master Feb 2, 2023
@arogge arogge deleted the dev/pstorz/master/rename-virtualfull-test branch February 2, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants