Skip to content

btraceback: make the gdb script processing failsafe#1334

Merged
arogge merged 3 commits intomasterfrom
dev/pstorz/master/gdb-script-failsave
Dec 20, 2022
Merged

btraceback: make the gdb script processing failsafe#1334
arogge merged 3 commits intomasterfrom
dev/pstorz/master/gdb-script-failsave

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Dec 17, 2022

gdb stops processing a script file at the first error. This can lead to missing information in the backtraces.
Instead of running the gdb script via -batch -x <scriptfile>, we now just read the scriptfile from stdin, so that gdb will just continue with the next command if one command fails.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@pstorz pstorz requested a review from arogge December 17, 2022 15:32
@pstorz pstorz force-pushed the dev/pstorz/master/gdb-script-failsave branch from 5ecf333 to b118754 Compare December 19, 2022 08:51
@arogge arogge force-pushed the dev/pstorz/master/gdb-script-failsave branch 2 times, most recently from cf93b7b to 97b70eb Compare December 20, 2022 12:06
@arogge arogge force-pushed the dev/pstorz/master/gdb-script-failsave branch from 97b70eb to 9aeaf74 Compare December 20, 2022 12:07
@arogge arogge merged commit 4adbf42 into master Dec 20, 2022
@arogge arogge deleted the dev/pstorz/master/gdb-script-failsave branch December 20, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants