Skip to content

dird: fix for crash when starting rescheduled jobs#1327

Merged
pstorz merged 6 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-dir-crash-msgchan
Dec 9, 2022
Merged

dird: fix for crash when starting rescheduled jobs#1327
pstorz merged 6 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-dir-crash-msgchan

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Dec 2, 2022 •
edited by pstorz
Loading

Thank you for contributing to the Bareos Project!

Description

This PR fixes a crash that occurs when starting rescheduled jobs.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • (will be added by pr-tool) Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@pstorz pstorz self-requested a review December 5, 2022 10:04
@pstorz pstorz self-assigned this Dec 5, 2022
pstorz
pstorz requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you found the fix that quick. Could you please add a short description to when the crash happened.(I.e. what crash is fixed).

@sduehr
Copy link
Member

sduehr commented Dec 6, 2022

This occured with the following config:

  Reschedule On Error = yes
  Reschedule Interval = 30 minutes
  Reschedule Times = 7
  Max Wait Time = 5 minutes

and it occured when the job was started at the rescheduled start time.

So the description should be:
This PR fixes a crash that occurs on starting rescheduled jobs.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-dir-crash-msgchan branch 5 times, most recently from 0228f1b to 3a28fb2 Compare December 7, 2022 11:33
@alaaeddineelamri alaaeddineelamri changed the title fix: possible fix for crash on dir dird: fix for crash when starting rescheduled jobs Dec 7, 2022
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-dir-crash-msgchan branch 4 times, most recently from 10a6ebb to 42b68da Compare December 8, 2022 09:29
pstorz
pstorz requested changes Dec 9, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, set -e is missing in testrunner-reschedule

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-dir-crash-msgchan branch from 42b68da to 74c247e Compare December 9, 2022 08:40
pstorz
pstorz approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit 8bf71ab into bareos:master Dec 9, 2022
@pstorz pstorz deleted the dev/alaaeddineelamri/master/fix-dir-crash-msgchan branch December 9, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alaaeddineelamri @sduehr @pstorz