bareos-fd-postgres: properly close database connection#1326
Merged
arogge merged 5 commits intobareos:masterfrom Dec 7, 2022
Merged
bareos-fd-postgres: properly close database connection#1326arogge merged 5 commits intobareos:masterfrom
arogge merged 5 commits intobareos:masterfrom
Conversation
17 tasks
Member
|
Hi, |
arogge
approved these changes
Dec 5, 2022
Member
arogge
left a comment
There was a problem hiding this comment.
Looks great! Thanks you very much.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will properly close the database connection after a Postgres WAL backup was made. As far as I could see a call to
close()is completely missing in the current code. As the the connection may already been closed I put it in a try/except to ignore all errors that may occur.On my test system this prevents the PostgreSQL server to log
unexpected EOF on client connection with an open transactionevery backup.
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems