Skip to content

dird: stored: set statistics collection as deprecated#1320

Merged
pstorz merged 8 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/mark-statistics-collection-deprecated
Dec 1, 2022
Merged

dird: stored: set statistics collection as deprecated#1320
pstorz merged 8 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/mark-statistics-collection-deprecated

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Nov 24, 2022 •
edited by pstorz
Loading

Thank you for contributing to the Bareos Project!

Description

This PR sets the statistics collections as deprecated.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/mark-statistics-collection-deprecated branch 2 times, most recently from 31ab23c to ac5977a Compare December 1, 2022 08:11
@pstorz pstorz self-assigned this Dec 1, 2022
@pstorz pstorz self-requested a review December 1, 2022 10:59
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/mark-statistics-collection-deprecated branch from ac5977a to 9d4347a Compare December 1, 2022 12:05
pstorz
pstorz requested changes Dec 1, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! See comments

pstorz
pstorz approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz enabled auto-merge December 1, 2022 13:23
@pstorz pstorz merged commit 4559f13 into bareos:master Dec 1, 2022
@pstorz pstorz deleted the dev/alaaeddineelamri/master/mark-statistics-collection-deprecated branch December 5, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alaaeddineelamri @pstorz