webui: patch zf2 to eliminate a php warning caused by zend-stdlib#1305
Merged
pstorz merged 2 commits intobareos:masterfrom Nov 13, 2022
frb121:dev/fbergkemper/master/fix-zend-stdlib-warning
Merged
webui: patch zf2 to eliminate a php warning caused by zend-stdlib#1305pstorz merged 2 commits intobareos:masterfrom frb121:dev/fbergkemper/master/fix-zend-stdlib-warning
pstorz merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/fix-zend-stdlib-warning
Conversation
bruno-at-bareos
approved these changes
Nov 8, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Tested no more warning are visible.
Need a changelog entry
bruno-at-bareos
approved these changes
Nov 8, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Warning are not more present in PhP log.
Changelog fixed.
frb121
commented
Nov 8, 2022
frb121
commented
Nov 8, 2022
frb121
commented
Nov 9, 2022
frb121
commented
Nov 9, 2022
arogge
reviewed
Nov 10, 2022
Use break instead of continue inside switch. See: zendframework/zend-stdlib@d0cd1d0
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use break instead of continue inside switch.
See: zendframework/zend-stdlib@d0cd1d0
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems##### Tests