backup.cc: fail backup when Write Bootstrap to pipe fails#1296
Merged
pstorz merged 6 commits intobareos:masterfrom Oct 31, 2022
Conversation
pstorz
requested changes
Oct 27, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
See my comments. I did not understand completely the need for the changes for thread_list.cc.
added 3 commits
October 28, 2022 19:42
in the PR that deprecated `Maximum Connections`, check for a maximum number of threads were removed, and thread counts are no more capped. However, the thread_list test was not correctly updated to reflect that, so now we removed the expectation and removed the max connections cap in the test
1c017be to
ba99418
Compare
pstorz
requested changes
Oct 31, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
I have updated the pipe error message in sync with e.g. fd_cmds.cc:732
Also answered to the comments on equal handling of the errors if the file cannot be opened.
Write Bootstrap directive failsWrite Bootstrap to pipe fails
pstorz
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
When using a pipe in the
Write Bootstrapdirective, if the given command after the pipe fails, the job still is successful.This PR checks for the return value of the pipe and makes the job fail in case of errors.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems