winbareos.nsi: fix working directory in configure.sed#1288
Merged
Conversation
This was referenced Oct 22, 2022
bruno-at-bareos
requested changes
Oct 26, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
- Removing offending commit for matrix and check_sources
- Add changelog line
Contributor
|
When doing the requested changes, also backport them to the two others PR |
f64a030 to
11f8afc
Compare
bruno-at-bareos
approved these changes
Oct 27, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Still need a CHANGELOG otherwise good
That makes sure that sed.exe will work in the bareos directory
d1a93ba to
8d8ce85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the working directory syntax and order in configure.sed
We also improve the installed plugins directory content
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsTests
Manually checked.