Skip to content

daemons: deprecate Maximum Connections configuration option#1285

Merged
arogge merged 4 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/s5216-deprecate-MaximumConnections
Oct 25, 2022
Merged

daemons: deprecate Maximum Connections configuration option#1285
arogge merged 4 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/s5216-deprecate-MaximumConnections

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Oct 19, 2022

Thank you for contributing to the Bareos Project!

This PR deprecates the Maximum Connections configuration option and removes all related checks in the code.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to rerun bareos-check-sources on this one.
Looks great otherwise!

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5216-deprecate-MaximumConnections branch 3 times, most recently from 6213529 to debff9e Compare October 24, 2022 13:39
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5216-deprecate-MaximumConnections branch from debff9e to 7448f7f Compare October 25, 2022 15:54
@arogge arogge merged commit 8f23547 into bareos:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants