filed: stored: deprecate compatible config option#1284
Merged
arogge merged 3 commits intobareos:masterfrom Oct 25, 2022
Merged
Conversation
arogge
reviewed
Oct 19, 2022
Member
There was a problem hiding this comment.
It seems like our versions of clang-format differ on how to format the foreach_alist().
Also, I noticed that neither the FD nor the SD prints the deprecation warning on startup. It does when invoking with -t, but not during normal startup. We may want to figure out why (and if that is a regression in Bareos 22 or not).
cad600b to
a176b4b
Compare
arogge
reviewed
Oct 25, 2022
Member
arogge
left a comment
There was a problem hiding this comment.
looks great, lacks a CHANGELOG record though.
added 3 commits
October 25, 2022 17:32
messaging code was moved before daemon goes into background to make sure messages can be displayed on console
a176b4b to
68c36df
Compare
arogge
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR deprecates the
compatibleconfiguration option without removing it or modifying the behaviour.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems