Skip to content

webui: fix job timeline x-axis UTC timestamp issue#1283

Merged
pstorz merged 3 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/fix-timeline
Nov 13, 2022
Merged

webui: fix job timeline x-axis UTC timestamp issue#1283
pstorz merged 3 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/fix-timeline

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Oct 18, 2022

We need to explicitly convert the retrieved timestamps to UTC timestamps and push those formatted to seconds since Unix epoch into the chart.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@frb121 frb121 self-assigned this Oct 18, 2022
@frb121 frb121 requested a review from pstorz October 19, 2022 13:13
@frb121 frb121 requested review from sebastianlederer and removed request for pstorz October 28, 2022 08:59
@frb121 frb121 assigned sebastianlederer and unassigned frb121 Oct 28, 2022
frb121 and others added 3 commits November 3, 2022 17:33
We need to explicitly convert the retrieved timestamps to UTC timestamps
and push those formatted to seconds since Unix epoch into the chart.
Signed-off-by: Sebastian Lederer <sebastian.lederer@dass-it.de>
Copy link
Collaborator

@sebastianlederer sebastianlederer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as intended now, manually verified in web browser.

@pstorz pstorz merged commit 5eb5d79 into bareos:master Nov 13, 2022
@frb121 frb121 deleted the dev/fbergkemper/master/fix-timeline branch April 21, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants