webui: fix job timeline x-axis UTC timestamp issue#1283
Merged
pstorz merged 3 commits intobareos:masterfrom Nov 13, 2022
frb121:dev/fbergkemper/master/fix-timeline
Merged
webui: fix job timeline x-axis UTC timestamp issue#1283pstorz merged 3 commits intobareos:masterfrom frb121:dev/fbergkemper/master/fix-timeline
pstorz merged 3 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/fix-timeline
Conversation
We need to explicitly convert the retrieved timestamps to UTC timestamps and push those formatted to seconds since Unix epoch into the chart.
Signed-off-by: Sebastian Lederer <sebastian.lederer@dass-it.de>
sebastianlederer
approved these changes
Nov 9, 2022
Collaborator
sebastianlederer
left a comment
There was a problem hiding this comment.
works as intended now, manually verified in web browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to explicitly convert the retrieved timestamps to UTC timestamps and push those formatted to seconds since Unix epoch into the chart.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems