stored: emit warnings for Maximum Concurrent Jobs in device configs#1282
Merged
pstorz merged 7 commits intobareos:masterfrom Nov 25, 2022
Conversation
arogge
reviewed
Oct 20, 2022
arogge
reviewed
Oct 20, 2022
.../source/manually_added_config_directive_descriptions/sd-device-MaximumConcurrentJobs.rst.inc
Outdated
Show resolved
Hide resolved
c6bada3 to
58c3ce6
Compare
58c3ce6 to
584b3fa
Compare
6112111 to
3c9a103
Compare
pstorz
requested changes
Nov 4, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Do we really need to import everything from fmt while we only want some files?
Other than that please see my comments
.../source/manually_added_config_directive_descriptions/sd-device-MaximumConcurrentJobs.rst.inc
Outdated
Show resolved
Hide resolved
Member
|
We don't need all files from libfmt, but we also don't need all files from CLI11 or droplet either - still they were added as a complete subtree. |
c9257f9 to
1834b65
Compare
3906ba2 to
166866c
Compare
git-subtree-dir: third-party/fmt git-subtree-split: a33701196adfad74917046096bf5a2aa0ab0bb50
166866c to
d3fa97b
Compare
This adds the device name to all device-based warnings in the SD.
d3fa97b to
9532cdd
Compare
Maximum Concurrent Jobs in device configurationsMaximum Concurrent Jobs in device configurations
Maximum Concurrent Jobs in device configurationsMaximum Concurrent Jobs in device configs
Maximum Concurrent Jobs in device configsMaximum Concurrent Jobs in device configs
30bb83e to
9532cdd
Compare
…i/master/s5279-concurrent-warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR adds some warning concerning the usage of
Maximum Concurrent Jobsin device configurations.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems