Skip to content

webui: introduce subscription backup unit report#1280

Merged
joergsteffens merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5170
Dec 14, 2022
Merged

webui: introduce subscription backup unit report#1280
joergsteffens merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5170

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Oct 17, 2022 •
edited by joergsteffens
Loading

Introduces an additional view to the director module where a backup unit report can be retrieved and downloaded in JSON format.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@frb121 frb121 self-assigned this Oct 17, 2022
joergsteffens
joergsteffens reviewed Oct 17, 2022
View reviewed changes
@frb121 frb121 marked this pull request as ready for review October 24, 2022 11:16
@frb121 frb121 requested a review from joergsteffens October 24, 2022 11:16
@frb121 frb121 assigned joergsteffens and unassigned frb121 Oct 28, 2022
joergsteffens
joergsteffens requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, some improvements. Please you this as a bases for further changes.

@joergsteffens joergsteffens mentioned this pull request Nov 15, 2022
Merged
16 tasks
@frb121 frb121 changed the title webui: introduce subscription module webui: introduce subscription status Nov 15, 2022
@frb121 frb121 requested a review from joergsteffens November 15, 2022 17:23
@frb121 frb121 assigned joergsteffens and unassigned frb121 Nov 15, 2022
@frb121 frb121 changed the title webui: introduce subscription status webui: introduce subscription backup unit report Nov 15, 2022
@frb121
Copy link
Contributor Author

frb121 commented Nov 16, 2022

Changes pushed including some further suggestions. Please review, thank you.

joergsteffens
joergsteffens requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I updated the text on the subscription page, tested it again and fixed some small thinks.
What still needs improvement is the handling of insufficient permissions:
Insufficient permissions are not clearly indicated. Instead, the command output is just displayed:
status subscription: needs access to all client, job and fileset resources.
Expected result: warning banner: insufficient permissions, required .... and the download button should also be invisible.

@frb121 frb121 requested a review from joergsteffens December 12, 2022 10:48
joergsteffens
joergsteffens approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes. Please squash the commits before merging.

@frb121
webui: introduce subscription module
01ae2e9 
Introduces a new module named "Subscription".
@frb121
update CHANGELOG.md
cb3d22a 
Signed-off-by: Frank Bergkemper <frank.bergkemper@bareos.com>
@frb121
Copy link
Contributor Author

frb121 commented Dec 14, 2022

Removed core changes from this branch that have already been merged into master by another PR. See https://github.com/fbergkemper/bareos/commit/4cef162b6ec0e669ff3acf4a23281b65a164a79d ( #1312 ). Squashed the commits and pushed a CHANGELOG.md update.

@joergsteffens joergsteffens merged commit 9e3e183 into bareos:master Dec 14, 2022
@frb121 frb121 deleted the dev/fbergkemper/master/s5170 branch April 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joergsteffens joergsteffens joergsteffens approved these changes

Assignees

@joergsteffens joergsteffens

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frb121 @joergsteffens @pstorz