lib: make foreach_res() reload-safe#1279
Merged
pstorz merged 9 commits intobareos:masterfrom Nov 4, 2022
Merged
Conversation
pstorz
reviewed
Oct 17, 2022
pstorz
reviewed
Oct 26, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good. Maybe we will get unused variabe warnings for the _config_table_.
73d64ae to
4db5010
Compare
4db5010 to
498f9f1
Compare
The new test does a foreach_res while another thread reloads the configuration again and again.
This patch extends the foreach_res() macro so that the loop will survive a configuration reload.
With alist being a cleanly typed template, we can omit all the type casts in foreach_alist() and have it type safe. This produces some issues with the existing usages which are also fixed.
Turn the old C-style cast using typeof() into a modern C++ static_cast using decltype().
498f9f1 to
e3291d6
Compare
pstorz
approved these changes
Nov 4, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good! I only applied the check-sources changes.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep a reference to the config while looping over configuration resources with
foreach_res().The PR also removes uses of the GCC extension
typeof()which are mostly not needed anymore and can be replaced withdecltype()where still required.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsTests