Skip to content

stored: systemtests: docs: checkpoints improvements#1277

Merged
pstorz merged 21 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/s5287-checkpoints-improvements
Oct 25, 2022
Merged

stored: systemtests: docs: checkpoints improvements#1277
pstorz merged 21 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/s5287-checkpoints-improvements

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Oct 13, 2022

Thank you for contributing to the Bareos Project!

This PR disables checkpoints when spooling, improves tests, and adds extra documentation about checkpoints.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5287-checkpoints-improvements branch from 7c9a109 to 35c410e Compare October 20, 2022 08:55
@alaaeddineelamri alaaeddineelamri marked this pull request as draft October 20, 2022 13:29
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5287-checkpoints-improvements branch 7 times, most recently from ef9c1c5 to 452a3e5 Compare October 22, 2022 09:50
@alaaeddineelamri alaaeddineelamri marked this pull request as ready for review October 24, 2022 11:14
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5287-checkpoints-improvements branch from 452a3e5 to 0c5646c Compare October 24, 2022 13:33
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some info to the docs. I hope that makes sense.

Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change please :)

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5287-checkpoints-improvements branch from 1f2a5b1 to ed63776 Compare October 25, 2022 09:01
@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/s5287-checkpoints-improvements branch from ed63776 to 46b94d5 Compare October 25, 2022 11:07
@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/s5287-checkpoints-improvements branch from f68a555 to 51da174 Compare October 25, 2022 11:13
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. One final build and I will merge it.

@pstorz pstorz merged commit a5a3dfc into bareos:master Oct 25, 2022
@pstorz pstorz deleted the dev/alaaeddineelamri/master/s5287-checkpoints-improvements branch October 25, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants