Skip to content

webui: extend restore to handle plugin options#1276

Merged
sduehr merged 3 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s4962
Dec 2, 2022
Merged

webui: extend restore to handle plugin options#1276
sduehr merged 3 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s4962

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Oct 11, 2022 •
edited by sduehr
Loading

Extends the restore module to allow the input of plugin options for restoring backup jobs that used a plugin.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@frb121 frb121 self-assigned this Oct 11, 2022
@frb121 frb121 marked this pull request as ready for review November 7, 2022 09:55
@joergsteffens joergsteffens requested a review from sduehr November 10, 2022 11:09
@joergsteffens joergsteffens assigned sduehr and unassigned frb121 Nov 10, 2022
sduehr
sduehr requested changes Nov 21, 2022
View reviewed changes
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good so far, only suggested some changes.
Could you please add some documentation at
https://docs.bareos.org/master/IntroductionAndTutorial/BareosWebui.html#available-restore-parameters

@frb121
Copy link
Contributor Author

frb121 commented Nov 22, 2022

Documentation added, please see 5cb73b6 .

@frb121 frb121 requested a review from sduehr November 22, 2022 13:30
@frb121 frb121 removed their assignment Nov 22, 2022
sduehr
sduehr requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or remove the "s" in $filesets_pluginjob in the lines 119 and 121 of ClientModel.php

@sduehr sduehr assigned frb121 and unassigned sduehr Nov 23, 2022
@frb121 frb121 requested a review from sduehr November 24, 2022 15:14
@frb121 frb121 assigned sduehr and unassigned frb121 Nov 24, 2022
sduehr
sduehr approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now.

@sduehr sduehr enabled auto-merge November 28, 2022 14:42
@sduehr sduehr merged commit 45a35d0 into bareos:master Dec 2, 2022
@frb121 frb121 deleted the dev/fbergkemper/master/s4962 branch April 21, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sduehr sduehr sduehr approved these changes

Assignees

@sduehr sduehr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frb121 @sduehr @pstorz