dird: do device reservation as late as possible, i.e. after run before job scripts#1273
Merged
pstorz merged 14 commits intobareos:masterfrom Nov 30, 2022
Conversation
a458656 to
7501c11
Compare
7501c11 to
108a688
Compare
108a688 to
5b19f52
Compare
run before job scripts
pstorz
requested changes
Nov 7, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
I applied the bareos-check-sources changes.
I think it would make sense that we add the information to the documentation. that now the device reservation is done after the run before sciripts are completed
bea156f to
731db20
Compare
289d3e7 to
92fafcc
Compare
a96f905 to
629b7ea
Compare
and move variable declarations
9b2cfde to
d38d352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bareos used to reserve the devices very early, even before the
run before job scripts.When the scripts are used to e.g. create a database dump which takes a very long time,
the storage device is blocked while no data is being written.
This PR makes sure devices are reserved at the latest time possible before starting the physical writing.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsTests