Skip to content

build: enable compiling on ARM#1270

Merged
pstorz merged 3 commits intomasterfrom
dev/joergs/master/arm
Oct 24, 2022
Merged

build: enable compiling on ARM#1270
pstorz merged 3 commits intomasterfrom
dev/joergs/master/arm

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Sep 30, 2022

While trying to compile and test (ctest) Bareos on ARM (using qemu), I had to do 2 small changes to make it work.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use static_cast instead of c casts, see https://google.github.io/styleguide/cppguide.html#Casting

@pstorz pstorz changed the title improve portability build: enable compiling on arm Oct 19, 2022
@pstorz pstorz changed the title build: enable compiling on arm build: enable compiling on ARM Oct 19, 2022
@joergsteffens joergsteffens requested a review from pstorz October 20, 2022 12:07
@joergsteffens
Copy link
Member Author

Applied suggestions, appiled bareos-check-sources, rebased and force-pushed (because it is a trivial PR).

@pstorz pstorz force-pushed the dev/joergs/master/arm branch from 2ca26ba to 8f96f7e Compare October 21, 2022 08:56
@pstorz pstorz force-pushed the dev/joergs/master/arm branch from 8f96f7e to 78d825a Compare October 21, 2022 08:58
@pstorz pstorz merged commit ca074d3 into master Oct 24, 2022
@pstorz pstorz deleted the dev/joergs/master/arm branch October 24, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants