Conversation
pstorz
requested changes
Oct 19, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Better use static_cast instead of c casts, see https://google.github.io/styleguide/cppguide.html#Casting
8469f5f to
2ca26ba
Compare
Member
Author
|
Applied suggestions, appiled bareos-check-sources, rebased and force-pushed (because it is a trivial PR). |
2ca26ba to
8f96f7e
Compare
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
8f96f7e to
78d825a
Compare
pstorz
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to compile and test (ctest) Bareos on ARM (using qemu), I had to do 2 small changes to make it work.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems