Skip to content

docs: add FAQ entry about howto upgrade from Bareos < 20 with Bareos Python packages installed#1260

Merged
joergsteffens merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/docs-fix-upgrade-19-to-20-ubuntu-18.04
Sep 27, 2022
Merged

docs: add FAQ entry about howto upgrade from Bareos < 20 with Bareos Python packages installed#1260
joergsteffens merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/docs-fix-upgrade-19-to-20-ubuntu-18.04

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Sep 15, 2022 •
edited by joergsteffens
Loading

This PR add instructions to FAQ Bareos chapter about python plugin broken packages with apt upgrade

[OP #5250] [OP #5155]

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@bruno-at-bareos bruno-at-bareos added the documentation This PR changes only documentation label Sep 15, 2022
joergsteffens
joergsteffens requested changes Sep 23, 2022
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with bareos-19.2 and packages bareos-filedaemon and bareos-filedaemon-python-plugin(and the automatic dependency bareos-common).

While apt upgrade bareos-filedaemon fails, you can work around it by:

apt install bareos-filedaemon

or

apt full-upgrade bareos-filedaemon

will both succeed, but remove the package bareos-filedaemon-python-plugin.
However, if you specify

apt full-upgrade bareos-filedaemon bareos-filedaemon-python3-plugin

or even only

apt full-upgrade bareos-filedaemon-python3-plugin

or

apt install bareos-filedaemon bareos-filedaemon-python3-plugin

or

apt install bareos-filedaemon-python3-plugin

will all succeed and achieve what is requested.
Of course, same is true if you replace bareos-filedaemon-python3-plugin by bareos-filedaemon-python2-plugin

Given this, I'm not sure it is worth to spend a section in the Update chapter for it, as it only affects old versions. But I understood, that there have been questions about this. Would placing the section into https://docs.bareos.org/Appendix/FAQ.html instead be helpful?

@bruno-at-bareos
Copy link
Contributor Author

bruno-at-bareos commented Sep 26, 2022

Hi @joergsteffens thanks a lot for your precious addition and tests.
I really like the

apt full-upgrade bareos-filedaemon bareos-filedaemon-python3-plugin trick and I agree that should do something with this and will more update the FAQ than the upgrade.

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/docs-fix-upgrade-19-to-20-ubuntu-18.04 branch from 21f1dce to 84f9c99 Compare September 26, 2022 14:59
joergsteffens
joergsteffens requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added a few minor comments.

@joergsteffens
Copy link
Member

joergsteffens commented Sep 26, 2022

I suggest renaming this PR to
docs: add FAQ entry about howto upgrade from Bareos < 20 with Bareos Python packages installed

@bruno-at-bareos bruno-at-bareos changed the title docs: Document howto upgrade from generic python plugin docs: add FAQ entry about howto upgrade from Bareos < 20 with Bareos Python packages installed Sep 27, 2022
@bruno-at-bareos
Copy link
Contributor Author

bruno-at-bareos commented Sep 27, 2022

All changes applied, once agreed I will squash I propose to add the CHANGELOG

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/docs-fix-upgrade-19-to-20-ubuntu-18.04 branch from 00089e3 to 879f63d Compare September 27, 2022 07:53
joergsteffens
joergsteffens approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well.

bruno-at-bareos and others added 2 commits September 27, 2022 14:26
@bruno-at-bareos @joergsteffens
docs: Document howto upgrade from generic python plugin
2393928 
- Add instructions to FAQ about python plugin `broken package`
  with apt upgrade

[OP #5250] [OP #5155]

Co-authored-by: Jörg Steffens <joergsteffens@users.noreply.github.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos
update CHANGELOG.md
9834b8b 
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/docs-fix-upgrade-19-to-20-ubuntu-18.04 branch from 879f63d to 9834b8b Compare September 27, 2022 12:30
@joergsteffens joergsteffens merged commit b7e3d8d into bareos:master Sep 27, 2022
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/docs-fix-upgrade-19-to-20-ubuntu-18.04 branch September 29, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joergsteffens joergsteffens joergsteffens approved these changes

Assignees

@joergsteffens joergsteffens

Labels

documentation This PR changes only documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bruno-at-bareos @joergsteffens