webui: fix password string length limitation#1251
Merged
Conversation
c0f5c2a to
edc1e44
Compare
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Nice improvement. Shouldn't we let a comment about the raise to 128 for Name length ?
Contributor
Author
It is just a small additional adjustment to correspond with https://docs.bareos.org/Configuration/CustomizingTheConfiguration.html#datatype-name which I don't think needs to be mentioned explicitly. |
bruno-at-bareos
approved these changes
Sep 13, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
This PR is now approved, can be merged once green on Jenkins.
@pstorz can you take care of this one ?
This PR removes the max string length value from the form data input filter validator for the password input field to allow passwords longer than 64 characters. Fixes #1480: password string length limitation
0ff20a8 to
d69cdcc
Compare
pstorz
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the max string length value from the form data input filter validator for the password input field to allow passwords longer than 64 characters.
Fixes #1480: password string length limitation
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests