Skip to content

docs: usage of the add_bareos_repositories.sh script#1248

Merged
joergsteffens merged 3 commits intobareos:masterfrom
joergsteffens:dev/joergs/master/add_bareos_repositories
Sep 27, 2022
Merged

docs: usage of the add_bareos_repositories.sh script#1248
joergsteffens merged 3 commits intobareos:masterfrom
joergsteffens:dev/joergs/master/add_bareos_repositories

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Sep 6, 2022 •
edited by bruno-at-bareos
Loading

Describe add_bareos_repositories.sh for all platforms it is available.
Refer to download.bareos.org and to download.bareos.com.
Split Installation chapter into Server installation and Client installation.
Move Mac OS Installation and Universal Linux Client into Client installation chapter.
Refer to the Windows installation chapter.

Note: please don't label with documentation. Also the packages needs to be builded.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • [ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

bruno-at-bareos
bruno-at-bareos reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a correct description for the PR + a changelog entry.
Need discussion about redundant information (start == debian)
Changing other os would be a nice to have.
Label documentation so Jenkins build it (done)

@bruno-at-bareos bruno-at-bareos added the documentation This PR changes only documentation label Sep 7, 2022
@joergsteffens joergsteffens added jenkins_repotest_nodebug and removed documentation This PR changes only documentation labels Sep 8, 2022
@joergsteffens joergsteffens force-pushed the dev/joergs/master/add_bareos_repositories branch from 0c91a86 to cd03d27 Compare September 23, 2022 12:27
@joergsteffens joergsteffens marked this pull request as ready for review September 23, 2022 12:30
@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented Sep 26, 2022

Hi @joergsteffens documentation hasn't been builded, so final result can't be seen in publish CD.
Did you have a way to do it at the same time than the packages (I don't pick the point why they need to be builded).

@joergsteffens joergsteffens added the documentation This PR changes only documentation label Sep 26, 2022
@joergsteffens
Copy link
Member Author

joergsteffens commented Sep 26, 2022

Building also the packages have been a requirement in the past, as this has been the only way to create the add_bareos_repositories.sh scripts in the repositories. Now that this change is merged, building only the documentation is sufficient. I adapted the PR accordingly.

@joergsteffens
Copy link
Member Author

joergsteffens commented Sep 26, 2022

Documentation is now available:
https://download.bareos.org/bareos/experimental/CD/PR-1248/BareosMainReference/

@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented Sep 26, 2022

Documentation is now available: https://download.bareos.org/bareos/experimental/CD/PR-1248/BareosMainReference/

Actually the content there is quite ugly look like a mix between old and new version
Take a look at https://download.bareos.org/bareos/experimental/CD/PR-1248/BareosMainReference/IntroductionAndTutorial/InstallingBareos.html and see that RHEL section is ok when SUSE not.

I've build it locally clean, and the pages were perfect, maybe the subfolder was not cleanup with the new build?

bruno-at-bareos
bruno-at-bareos requested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments, and the published needs I guess a fully cleanup.
Build locally, and I found it a really nice improvement for new adopter.

@joergsteffens joergsteffens force-pushed the dev/joergs/master/add_bareos_repositories branch from dab3e68 to 568c8ce Compare September 27, 2022 13:24
@joergsteffens
docs: usage of add_bareos_repositories.sh script
c5be7b4 
Describe add_bareos_repositories.sh for all platforms,
it is available.
Refer to downlaod.bareos.org and to download.bareos.com.
Split Installation chapter into Server installation and Client installation.
Move Univention Corporate Server section to Server installation chapter.
Move Mac OS Installation and Universal Linux Client into Client installation chapter.
Refer to the Windows installation chapter.
Remove outdated sections.
@joergsteffens
update CHANGELOG.md
caf6f22
@joergsteffens joergsteffens force-pushed the dev/joergs/master/add_bareos_repositories branch from 568c8ce to caf6f22 Compare September 27, 2022 14:24
bruno-at-bareos
bruno-at-bareos approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Approved for merge.

@joergsteffens joergsteffens merged commit f635940 into bareos:master Sep 27, 2022
@joergsteffens joergsteffens deleted the dev/joergs/master/add_bareos_repositories branch September 27, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

@bruno-at-bareos bruno-at-bareos

Labels

documentation This PR changes only documentation jenkins_repotest_nodebug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joergsteffens @bruno-at-bareos