Skip to content

tests: remove unused config files#1247

Merged
pstorz merged 13 commits intomasterfrom
dev/pstorz/master/remove-mon-confs
Sep 7, 2022
Merged

tests: remove unused config files#1247
pstorz merged 13 commits intomasterfrom
dev/pstorz/master/remove-mon-confs

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Aug 31, 2022 •
edited
Loading

We have a lot of *-mon conf files in the test directories that are not needed at all. This PR removes them.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

alaaeddineelamri
alaaeddineelamri reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done my review, and everything is ok.
I've removed some more unnecessary config files, so when you have time you can review them too and merge.

@pstorz pstorz changed the title tests: remove all unneeded *-mon.conf* files tests: cleanup config files: removed unused reorganized scheduler test config files Sep 7, 2022
@pstorz pstorz changed the title tests: cleanup config files: removed unused reorganized scheduler test config files tests: remove unused config files Sep 7, 2022
@pstorz pstorz force-pushed the dev/pstorz/master/remove-mon-confs branch from 03ce3cd to 15401dd Compare September 7, 2022 09:57
pstorz and others added 13 commits September 7, 2022 12:14
@pstorz
tests: remove all unneeded *-mon.conf* files
5b8739c
remove unnecessary config files from gtest configs
cf37170
regroup scheduler test configs in one folder
8ac4c24
@pstorz
update CHANGELOG.md
21c8077
Revert "remove unnecessary config files from gtest configs"
374c8a4 
This reverts commit cf37170.
Revert "regroup scheduler test configs in one folder"
b71b264 
This reverts commit 8ac4c24.
gtest bareos-configparser-tests: remove tray monitor config
c5a26b0
regroup scheduler test configs in one folder again
7691601
gtest scheduler tests: remove unnecessary scheduler files
2b4b2bd
dird_conf.cc: remove unnecessary bailout
2481399
gtest:tls_disabled : removed unnecessary config files
d261151
gtest:tls_psk_default_enabled: removed unnecessary config files
bb720c1
gtest:run-on-incoming-connect-interval: removed unnecessary config files
0b492fc
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/remove-mon-confs branch from 15401dd to 0b492fc Compare September 7, 2022 12:54
@pstorz pstorz merged commit a9d0e7a into master Sep 7, 2022
@pstorz pstorz deleted the dev/pstorz/master/remove-mon-confs branch September 7, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alaaeddineelamri alaaeddineelamri alaaeddineelamri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pstorz pstorz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pstorz @alaaeddineelamri