Update Pull Request template: handling CHANGELOG.md#1243
Merged
joergsteffens merged 5 commits intomasterfrom Sep 9, 2022
Merged
Update Pull Request template: handling CHANGELOG.md#1243joergsteffens merged 5 commits intomasterfrom
joergsteffens merged 5 commits intomasterfrom
Conversation
pstorz
requested changes
Aug 29, 2022
pull_request_template.md
Outdated
| - [ ] Separate commit for this PR in the CHANGELOG.md, PR number referenced is same | ||
| - [ ] Commit descriptions are understandable and well formatted | ||
| - [ ] If backport: add original PR number and target branch at top of this file: **Backport of PR#000 to bareos-2x** | ||
| - [ ] Separate commit for CHANGELOG.md changes (message: "update CHANGELOG.md" or "update CHANGELOG.md for PR #0000"). PR number is verified. |
Contributor
There was a problem hiding this comment.
Suggested change
| - [ ] Separate commit for CHANGELOG.md changes (message: "update CHANGELOG.md" or "update CHANGELOG.md for PR #0000"). PR number is verified. | |
| +- [ ] Separate commit exists for CHANGELOG.md with this PR changes and number placed on top of corresponding section. (message: "update CHANGELOG.md" or "update CHANGELOG.md for PR #0000") |
But maybe not better ;-)
pstorz
reviewed
Sep 1, 2022
| - [ ] Code comments are correct (logically and spelling) | ||
| - [ ] Required documentation changes are present and part of the PR | ||
| - [ ] `bareos-check-sources --since-merge` does not report any problems | ||
| - [ ] `git status` should not report modifications in the source tree after building and testing |
Contributor
There was a problem hiding this comment.
Why did we remove that line?
Member
Author
There was a problem hiding this comment.
@pstorz said, that this have not happened for a long time and can therefore be removed.
Contributor
There was a problem hiding this comment.
I would have keep it, especially for external contribution, but we can try without and see.
Contributor
|
With the new place of comments the section in Changelog, this PR should reorder them, so how to do it become an evidence. |
pstorz
approved these changes
Sep 8, 2022
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
1bb4cc5 to
c106d6a
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing