Skip to content

config: add FS Type = vfat in LinuxAll.conf for UEFI partition.#1236

Merged
pstorz merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/add-missing-vfat-in-linuxall.conf
Aug 29, 2022
Merged

config: add FS Type = vfat in LinuxAll.conf for UEFI partition.#1236
pstorz merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/add-missing-vfat-in-linuxall.conf

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Aug 23, 2022 •
edited by pstorz
Loading

This PR add FS Type = vfat to LinuxAll.conf so complete linux with UEFI partition will be backup and can be restored.
Small improvements done into doc Director.rst

OP#5186

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/add-missing-vfat-in-linuxall.conf branch from 1e0b840 to fb612de Compare August 24, 2022 07:29
@bruno-at-bareos bruno-at-bareos requested a review from pstorz August 25, 2022 10:08
@pstorz pstorz changed the title config: add FS Type = vfat in LinuxAll.conf for UEFI partition. config: add FS Type = vfat in LinuxAll.conf for UEFI partition. Aug 25, 2022
pstorz
pstorz requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the quotes around the directive in the changelog, nothing else.

Good work!

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/add-missing-vfat-in-linuxall.conf branch from b8b9c80 to 924812a Compare August 25, 2022 15:22
@bruno-at-bareos bruno-at-bareos requested a review from pstorz August 25, 2022 15:23
pstorz
pstorz approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@bruno-at-bareos
config: add FS Type = vfat in LinuxAll.conf for UEFI partition.
91f2d63 
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos
update CHANGELOG.md for PR#1236
5877968 
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/add-missing-vfat-in-linuxall.conf branch from 924812a to 5877968 Compare August 29, 2022 11:10
@pstorz pstorz merged commit e0e198a into bareos:master Aug 29, 2022
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/add-missing-vfat-in-linuxall.conf branch August 31, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bruno-at-bareos @pstorz