docs: improve wild(*) section#1228
Merged
joergsteffens merged 2 commits intobareos:masterfrom Aug 22, 2022
Merged
Conversation
0eac521 to
6eea323
Compare
joergsteffens
approved these changes
Aug 17, 2022
Member
joergsteffens
left a comment
There was a problem hiding this comment.
Nice. I've a few suggestions, but other than that, I approve.
Contributor
Author
|
Thanks for the review and suggestions, I've now applied them all. |
Member
|
Can you pleas resolve the CHANGELOG conflict? |
ae55f89 to
931b638
Compare
Contributor
Author
|
done |
931b638 to
81f27ae
Compare
Member
|
Thanks for applying the changes. Would you mind to squash the 3 commits together? |
- add a link to each section to FileSet Examples where the usage is explained. - add :bcommand:`estimate job=job-name listing` when estimate is shown - fix typos, and spacing. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> Co-authored-by: Jörg Steffens <joergsteffens@users.noreply.github.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
867589a to
a059484
Compare
Contributor
Author
|
done |
joergsteffens
approved these changes
Aug 22, 2022
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve the Wild(*) section of the documentation
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
[ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2xSource code quality
[ ] Source code changes are understandable[ ] Variable and function names are meaningful[ ] Code comments are correct (logically and spelling)bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing