Skip to content

devtools/dist-tarball.sh: create correct source name#1221

Merged
pstorz merged 3 commits intomasterfrom
dev/pstorz/master/backport-pr-1220
Aug 11, 2022
Merged

devtools/dist-tarball.sh: create correct source name#1221
pstorz merged 3 commits intomasterfrom
dev/pstorz/master/backport-pr-1220

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Aug 11, 2022

Forward-Port of PR #1220

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • [ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@pstorz pstorz requested a review from bruno-at-bareos August 11, 2022 12:17
@pstorz pstorz force-pushed the dev/pstorz/master/backport-pr-1220 branch from 7f0ca7f to c89f1a7 Compare August 11, 2022 12:19
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
(cherry picked from commit 00cd20d)
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to remove the additional blank line in CHANGELOG.md
Beside that: Approved, ready to merge once build.

@pstorz pstorz force-pushed the dev/pstorz/master/backport-pr-1220 branch from 30643ef to 455b8a3 Compare August 11, 2022 12:35
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice let's get dist!

@pstorz pstorz merged commit 8144204 into master Aug 11, 2022
@pstorz pstorz deleted the dev/pstorz/master/backport-pr-1220 branch August 11, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants