VMware plugin: Fixed: Restore to local file required API connection#1219
Merged
pstorz merged 3 commits intobareos:masterfrom Aug 23, 2022
Merged
VMware plugin: Fixed: Restore to local file required API connection#1219pstorz merged 3 commits intobareos:masterfrom
pstorz merged 3 commits intobareos:masterfrom
Conversation
Restoring a VM to a local file using the VMware plugin required a valid connection to the vSphere API. This makes a restore in a worst-case scenario where you lose your vCenter installation unnecessarily complicated. This commit fixes the option check logic and does not connect to the vCenter API when localvmdk is set to yes.
Code formatting with black and copyright year to comply with coding guidelines.
8473103 to
2f1aa09
Compare
sduehr
approved these changes
Aug 22, 2022
Member
sduehr
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution, looks good.
I only changed copyright year and the code formatting to comply with the guidelines, and resolved the CHANGELOG.md merge conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a VM to a local file using the VMware plugin required a valid
connection to the vSphere API.
This makes a restore in a worst-case scenario where you lose your
vCenter installation unnecessarily complicated.
This commit fixes the option check logic and does not connect to the
vCenter API when localvmdk is set to yes.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing