pruning: prune jobs doesn't ask for jobtypes anymore, and prunes all jobtypes except Archives (A)#1215
Merged
pstorz merged 26 commits intobareos:masterfrom Sep 19, 2022
Conversation
ca357b9 to
6169d8e
Compare
bruno-at-bareos
previously requested changes
Aug 18, 2022
Contributor
There was a problem hiding this comment.
del ctx manipulation has to be avoided.
We should also check if the 1000 limit is needed (query length limit in libpq)
pstorz also want to add
394: =================================================================
394: ==1123923==ERROR: LeakSanitizer: detected memory leaks
394:
394: Direct leak of 2640 byte(s) in 10 object(s) allocated from:
394: #0 0x7f4a738ae91f in __interceptor_malloc (/lib64/libasan.so.6+0xae91f)
394: #1 0x7f4a724f2fb1 in GetMemory(int) src/lib/mem_pool.cc:111
394:
394: SUMMARY: AddressSanitizer: 2640 byte(s) leaked in 10 allocation(s).
394: Process 1123923 has exited.
82710fc to
e8ac75e
Compare
2e2209e to
8bc7c25
Compare
pstorz
requested changes
Aug 25, 2022
377754f to
0b4aede
Compare
0b4aede to
1d85e4f
Compare
added 10 commits
September 12, 2022 11:31
1d85e4f to
26c3484
Compare
26c3484 to
a0c366d
Compare
pstorz
approved these changes
Sep 19, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work. I cleaned up one commit comment and removed the introduction and revert of the foreach_alist_no_null_check macro.
If build passes we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
prune jobscommand asks for job types but it actually just prunes all types anwyay (except Archive and Consolidate).This PR removes the job type choice and makes the
prune jobscommand prune all types except Archive (A), meaning that consolidate jobs now get pruned too.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
[ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2xSource code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests