Skip to content

stored: fix bcopy and test it in a system test#1211

Merged
pstorz merged 11 commits intomasterfrom
dev/pstorz/master/bcopy-test
Aug 19, 2022
Merged

stored: fix bcopy and test it in a system test#1211
pstorz merged 11 commits intomasterfrom
dev/pstorz/master/bcopy-test

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Jul 29, 2022

Description:

This PR fixes a crash that happens when using certain cli arguments with bcopy, bextract and bls.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
    - [ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@pstorz pstorz force-pushed the dev/pstorz/master/bcopy-test branch 2 times, most recently from a0a987e to 1f16812 Compare July 29, 2022 15:24
@pstorz pstorz self-assigned this Aug 4, 2022
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/bcopy-test branch from 5d4097e to 07c7e5b Compare August 4, 2022 13:47
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/bcopy-test branch from 07c7e5b to 0c8b83f Compare August 12, 2022 12:58
@pstorz pstorz force-pushed the dev/pstorz/master/bcopy-test branch from 0c8b83f to 41a6409 Compare August 17, 2022 10:53
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/bcopy-test branch from 41a6409 to 30ad032 Compare August 18, 2022 12:06
@pstorz pstorz merged commit 659b379 into master Aug 19, 2022
@pstorz pstorz deleted the dev/pstorz/master/bcopy-test branch August 19, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants