Add missing newline to job message for TLS handshake.#1209
Merged
pstorz merged 4 commits intobareos:masterfrom Aug 1, 2022
rainerjung:Log-message-missing-newline
Merged
Add missing newline to job message for TLS handshake.#1209pstorz merged 4 commits intobareos:masterfrom rainerjung:Log-message-missing-newline
pstorz merged 4 commits intobareos:masterfrom
rainerjung:Log-message-missing-newline
Conversation
Add missing newline to job messahe for TLS handshake. See the next case, cleartext handshake.
Contributor
|
Nice, maybe also time then to fix line 208 by removing the \n and adding also add_newline_in_joblog = true; |
Contributor
|
@rainerjung are you interested to do the whole PR process? It would be nice to have also your Name in AUTHORS file. |
Contributor
Author
|
I am not sure, whether I currently can find the time to do the non-release build and test it. So if you can proceed without strong involvement from my side, that would be great. I do not really care whether you include me in the AUTHORS or not, because it is a trivial change. But if you like so, you can add "Rainer Jung". Of course, if you need to discuss something technical about the patch, I am here to answer as far as I can. |
Always add newline to job message for TLS handshake. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing newline to job message for TLS handshake.
This PR will fix the missing new line in job log as seen like
instead expected result
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing