daemons: fix issue with group and users commandline options#1206
Merged
pstorz merged 11 commits intobareos:masterfrom Jul 26, 2022
Merged
Conversation
f922cc5 to
34d58e8
Compare
pstorz
requested changes
Jul 20, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good, only unified usage of c_str() would make sense.
34d58e8 to
3e614a8
Compare
65a870a to
ecd9295
Compare
pstorz
reviewed
Jul 25, 2022
pstorz
reviewed
Jul 25, 2022
pstorz
reviewed
Jul 25, 2022
pstorz
reviewed
Jul 25, 2022
pstorz
requested changes
Jul 25, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work, Please see the comments.
ecd9295 to
71c2b4a
Compare
updated daemons help messages
added 5 commits
July 26, 2022 13:01
Most of the bareos CLI options are used throughout tests and are therefore tested, meaning if there is any issue with one of those options, the tests that use them will break. This is valid for -f, -d, --dt, -c, --xs, etc. Certain other options like -u, -g, -r, -p are not tested, and there is no basic way to test if at least the daemons don't crash because of them.
update help doc
4dd7112 to
d67d8be
Compare
pstorz
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
After the introduction of the new CLI options, the
-p,-uand-goptions can make daemons crash. This PR fixes the issue.Also adding some helpful messages for the changed options.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests