Skip to content

Docs: Added Developer FAQ section with first question.#1202

Merged
pstorz merged 8 commits intobareos:masterfrom
HediBenFraj:dev/HediBenFraj/master/docs-developer-guide-FAQs
Sep 5, 2022
Merged

Docs: Added Developer FAQ section with first question.#1202
pstorz merged 8 commits intobareos:masterfrom
HediBenFraj:dev/HediBenFraj/master/docs-developer-guide-FAQs

Conversation

@HediBenFraj
Copy link
Contributor

@HediBenFraj HediBenFraj commented Jul 7, 2022

Description

In this PR i added a Developer FAQ section in documentation and a first question proposal.

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@HediBenFraj HediBenFraj added the documentation This PR changes only documentation label Jul 7, 2022
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/docs-developer-guide-FAQs branch from f306763 to 67948a2 Compare July 11, 2022 08:19
@joergsteffens joergsteffens marked this pull request as draft July 11, 2022 17:15
@HediBenFraj HediBenFraj changed the title Docs: Added Developer FAQs section with first question. Docs: Added Developer FAQ section with first question. Jul 12, 2022
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/docs-developer-guide-FAQs branch 2 times, most recently from 81382ff to c201de1 Compare July 12, 2022 10:47
@alaaeddineelamri alaaeddineelamri force-pushed the dev/HediBenFraj/master/docs-developer-guide-FAQs branch from c201de1 to fe65ed1 Compare August 17, 2022 14:46
@alaaeddineelamri alaaeddineelamri marked this pull request as ready for review August 26, 2022 08:58
@bruno-at-bareos bruno-at-bareos self-requested a review August 29, 2022 08:59
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal, I've added some suggestion you should revisit.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/HediBenFraj/master/docs-developer-guide-FAQs branch from d37e89e to ab89e61 Compare August 31, 2022 07:37
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice there's just a fix for the <> url to apply.
Otherwise for me it is approved.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/HediBenFraj/master/docs-developer-guide-FAQs branch from ab89e61 to dbc58c9 Compare August 31, 2022 12:26
@alaaeddineelamri alaaeddineelamri force-pushed the dev/HediBenFraj/master/docs-developer-guide-FAQs branch from dbc58c9 to 5500ce0 Compare August 31, 2022 12:35
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, now ready for merge.
@pstorz would you mind to?

@pstorz pstorz merged commit 9fdb3ab into bareos:master Sep 5, 2022
@pstorz pstorz deleted the dev/HediBenFraj/master/docs-developer-guide-FAQs branch September 5, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR changes only documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants