daemons: changing our custom daemon CLI parsing with CLI11#1187
Merged
joergsteffens merged 26 commits intobareos:masterfrom Jul 11, 2022
Merged
Conversation
c3bbf9b to
ce660b8
Compare
131815b to
6ebf335
Compare
6ebf335 to
b71c9d6
Compare
227de93 to
80d62ac
Compare
905de13 to
fbe7427
Compare
fbe7427 to
764009c
Compare
Member
joergsteffens
left a comment
There was a problem hiding this comment.
I'm not through all files, howver wanted to provide you the part of the review already done.
764009c to
b2e506f
Compare
9a3183d to
ce85b24
Compare
added readme ignore third-party in bareos-check-sources
Macros `P(x)` and `V(x)` create conflicts with CLI11. We decided to remove the macro all together and rename the function to be more expressive. Anecdote: V stands for 'Verhoog', which can be translated as "increment" from dutch. P stands for 'Prolaag', a madeup Dutch word of 'probeer verlaag', which can be translated as "try to decrease". These words were coined by Edsger W. Dijkstra.
Updated documentation
the initial reason for attracting attention, was that it made the build fail on certain conditions. updated documentation
gtest: add test for CLI help formatting
... and use them in the documentation. As before, some commands are only executed when docs-build-json is set. We now handle this by an if clause.
ce85b24 to
9a5bfca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to standardize daemon argument parsing using a third party library called CLI11.
Documentation can be found here and also here.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
[ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2xSource code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests