Skip to content

systemtest: fixed issues with systemtests not succeeding on first try#1186

Merged
pstorz merged 21 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-flaky-tests
Sep 19, 2022
Merged

systemtest: fixed issues with systemtests not succeeding on first try#1186
pstorz merged 21 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-flaky-tests

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Jun 1, 2022 •
edited by pstorz
Loading

Description

This pull request aims to fix certain systemtests that require running twice in order to succeed.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-flaky-tests branch 14 times, most recently from 5cbf709 to 1376b4b Compare August 1, 2022 13:21
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-flaky-tests branch 15 times, most recently from c721621 to 2125315 Compare August 9, 2022 08:17
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-flaky-tests branch 2 times, most recently from 8860242 to c38ca75 Compare September 14, 2022 10:39
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-flaky-tests branch from c38ca75 to 6215cd7 Compare September 15, 2022 08:47
pstorz
pstorz approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Alaa Eddine Elamri and others added 21 commits September 19, 2022 12:46
@pstorz
systemtest: rename encrypt-signature-tls-cert
39345c8
@pstorz
systemtests: separate testnames so they are not executed consecutively
c8b0448
@pstorz
systemtest: update scheduler backup test
af64d37 
scheduler
@pstorz
systemtest: fix gfapi systemtest sporadic fails
2e63750
@pstorz
py2plug-fd tests: stop server after stopping bareos
48cd7ac
@pstorz
systemtests: remove redundant bareos stops
2288374 
Since the `end_test` function automatically shuts down bareos when it is 
a single testrunner, stoping bareos before makes tests try to shutdown 
bareos twice which may be causing some sporadic errors
tls
@pstorz
commandline test: remove unnecessary autxflate from commandline test
ae399de
@pstorz
scripts/functions: introduce wait_for_jobs_to_terminate
2e059da 
(cherry picked from commit f5d50c8)

status what

(cherry picked from commit d10fde7)
@pstorz
use bash
1c4599d 
(cherry picked from commit 6a2077c)
@pstorz
check_for_zombie_jobs: add wait for running jobs to zombie job check
99f70e2
@pstorz
gtest: try binding six times
a6f0f83 
gtest: explicit bind error message


test sockets
@pstorz
gtest: try to listen 6 times
4feef9a
@pstorz
Updated CHANGELOG.md
05c241c
@pstorz
gtest: added log for bind and listen tries
1b721b1
@pstorz
Revert "systemtests: separate testnames so they are not executed cons…
14b80d7 
…ecutively"

This reverts commit d382baf.
@pstorz
Revert " systemtest: rename encrypt-signature-tls-cert"
4400a0f 
This reverts commit 470bf76.
@pstorz
rmeove extra waits
027d8cd
@pstorz
bareos-ctl-funcs: select first occurrence of the basename
556dc12
@pstorz
rename encrypt-signature
256ce17
@pstorz
rename py2plug-fd-local-fileset to py2plug-fd-fileset-basic
96a7d46
@pstorz
format: apply bareos-check-sources changes
a0d3898
@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/fix-flaky-tests branch from 6215cd7 to a0d3898 Compare September 19, 2022 10:47
@pstorz pstorz merged commit 6bf6989 into bareos:master Sep 19, 2022
@pstorz pstorz deleted the dev/alaaeddineelamri/master/fix-flaky-tests branch September 19, 2022 10:48
@sebsura sebsura mentioned this pull request Mar 27, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

@alaaeddineelamri alaaeddineelamri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alaaeddineelamri @pstorz