Merged
Conversation
pstorz
reviewed
Jul 28, 2022
pstorz
reviewed
Jul 28, 2022
pstorz
reviewed
Jul 28, 2022
pstorz
reviewed
Jul 28, 2022
pstorz
requested changes
Jul 28, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
I would suggest to move the "MD5 needs to be replaced by SHA256" to the end of the description. When trying to get bareos running on the fips machine, first the openssl needs to be fixed so that the daemons can even communicate, then the MD5 Problem pops up.
bruno-at-bareos
commented
Jul 28, 2022
af12dfc to
4194a0c
Compare
4194a0c to
8abc63c
Compare
94bc93e to
b14e1d5
Compare
e475a7f to
fe03d84
Compare
- Add Security FIPS section. Co-authored-by: Philipp Storz <philipp.storz@bareos.com> Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
fe03d84 to
2001c01
Compare
9 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a section to explain how to setup and check FIPS enabled computer.
backport should be limited to 21 version as only newer enterprise OS are concerned.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing