doc: clarifies checkfilechanges option use case (not intended for plugin)#1180
Merged
joergsteffens merged 2 commits intobareos:masterfrom Jun 23, 2022
Conversation
joergsteffens
requested changes
Jun 9, 2022
Member
joergsteffens
left a comment
There was a problem hiding this comment.
We also discussed to fix the behavior when using plugin filesets. Any progress on this? If yes, maybe this change is not required at all.
Contributor
Author
I've not yet seen any new PR for that. Do you want to put this PR on hold ? |
…lugin Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> Co-authored-by: Jörg Steffens <joergsteffens@users.noreply.github.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
780cbb0 to
ee6574d
Compare
joergsteffens
approved these changes
Jun 23, 2022
This was referenced Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about clarifying the option CheckFileChanges usage in documentation.
It will clearly state this option is reserved for File= resource type, and has to not be used with Plugin=
Referenced in bug #1452 and bug #1449
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing