dird: bconsole: add support for comma separated jobstatus values in list jobs command#1169
Merged
pstorz merged 4 commits intobareos:masterfrom May 5, 2022
Conversation
f655468 to
7574202
Compare
alaaeddineelamri
suggested changes
Apr 26, 2022
Contributor
alaaeddineelamri
left a comment
There was a problem hiding this comment.
Thank you for your effort, good work!
The PR is failing on FreeBSD, so take a look at that, something to do with the unordered_map
Make sure you run bareos-check-sources as it reports a few missing things
7574202 to
4e8c3d8
Compare
alaaeddineelamri
suggested changes
Apr 27, 2022
4e8c3d8 to
551c5a8
Compare
6cfb8e7 to
fa14542
Compare
fa14542 to
ec46887
Compare
ec46887 to
c7db51a
Compare
frb121
approved these changes
May 4, 2022
Contributor
frb121
left a comment
There was a problem hiding this comment.
Looks good to me as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changed the list jobs command to accept multiple values for jobstatus argument instead of one
exp : list jobs jobstatus=terminated,E,f
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests